RFR: 8323576: [Windows] Fallthrough to ::abort instead of os::infinite_sleep for noreturn methods [v2]

[David Holmes]

On Tue, 16 Jan 2024 06:22:45 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> os::infinite_sleep should only be used in very specific scenarios, and using it to satisfy compiler requirements for [[noreturn]] marked methods is a bad idea, since in the impossible case this will cause HotSpot to hang for a seemingly unknown reason. Fallthrough to ::abort instead, like other platforms do, to align Windows with them
>
> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - std::abort to ::abort in vmError_windows.cpp
>  - std::_Exit to ::_Exit in os_windows.cpp

Changes requested by dholmes (Reviewer).

src/hotspot/os/windows/os_windows.cpp line 4238:

> 4236:     ALLOW_C_FUNCTION(::exit, ::exit(exit_code);)
> 4237:   } else { // EPT_PROCESS_DIE
> 4238:     ::_Exit(exit_code);

I don't see any reason to change this line.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17366#pullrequestreview-1829059802
PR Review Comment: https://git.openjdk.org/jdk/pull/17366#discussion_r1457054274