RFR: 8314186: runtime/8176717/TestInheritFD.java failed with "Log file was leaked" [v2]

[Johan Sjölen]

On Thu, 11 Jan 2024 05:00:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change messages etc
>
> test/hotspot/jtreg/runtime/8176717/TestInheritFD.java line 309:
> 
>> 307:                 }
>> 308:             } catch (CompletionException e) {
>> 309:                 System.out.println("(Third VM) Timed out waiting for second VM: " + e.toString());
> 
> You don't know it timed out. The cause of the `CompletionException` may be something else. You should check the cause and then do your timeout message, else report an unexpected completion exception.

Thank you, I check if it's a `TimeoutException` that's the cause, and if so print that a timeout occurred, otherwise print the 'regular' exception message.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17325#discussion_r1458784146