RFR: 8314186: runtime/8176717/TestInheritFD.java failed with "Log file was leaked" [v2]

[David Holmes]

On Wed, 10 Jan 2024 14:45:52 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi,
>> 
>> This PR intends to make the test a bit more sturdy by looking for both the success string and the failure string, reporting that the test messed up if neither are found. I also removed the extra newline at the end of the file and did some special reporting in case of a `TimeoutException`.
>> 
>> Thanks!
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change messages etc

Changes requested by dholmes (Reviewer).

test/hotspot/jtreg/runtime/8176717/TestInheritFD.java line 259:

> 257:             throw new RuntimeException("Log file was leaked to the third VM.");
> 258:         } else {
> 259:             throw new RuntimeException("Found neither message, test failed to run correctly");

This is fine.

test/hotspot/jtreg/runtime/8176717/TestInheritFD.java line 309:

> 307:                 }
> 308:             } catch (CompletionException e) {
> 309:                 System.out.println("(Third VM) Timed out waiting for second VM: " + e.toString());

You don't know it timed out. The cause of the `CompletionException` may be something else. You should check the cause and then do your timeout message, else report an unexpected completion exception.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17325#pullrequestreview-1814663975
PR Review Comment: https://git.openjdk.org/jdk/pull/17325#discussion_r1448292806
PR Review Comment: https://git.openjdk.org/jdk/pull/17325#discussion_r1448294682