RFR: 8323994: gtest runner repeats test name for every single gtest assertion

Leonid Mesnik lmesnik at openjdk.org
Wed Jan 24 22:44:28 UTC 2024


On Thu, 18 Jan 2024 16:35:35 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

> If GTest fails multiple times within the same test (for example when EXPECT or ASSERT are used in a subroutine), `GTestResultParser` repeats the failing test multiple times in its report. 
> 
> Please refer to the existing issue for an example. 
> 
> We only need to see the failing test reported once, so this patch fixes that. 
> 
> Let me know your thoughts. 
> Cheers, 
> Sonia

Please remove space and update copyrights. Otherwise fix looks good.

test/hotspot/jtreg/gtest/GTestResultParser.java line 61:

> 59:                         case "failure":
> 60:                             String failedStr = testSuite + "::" + testCase;
> 61:                             if (! failedTests.contains(failedStr)) {

Please remove space between '! and failed..'.

-------------

Marked as reviewed by lmesnik (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17489#pullrequestreview-1842521959
PR Review Comment: https://git.openjdk.org/jdk/pull/17489#discussion_r1465630301


More information about the hotspot-runtime-dev mailing list