RFR: 8313306: More sensible reservation logging [v2]

[David Holmes]

On Mon, 29 Jan 2024 17:46:23 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> src/hotspot/os/aix/os_aix.cpp line 301:
>> 
>>> 299:       ErrnoPreserver ep;
>>> 300:       log_trace(os,map)("Cannot disclaim %p - %p (errno %d)\n", p, p + maxDisclaimSize, errno);
>>> 301:       trcVerbose("Cannot disclaim %p - %p (errno %d)\n", p, p + maxDisclaimSize, errno);
>> 
>> I don't think you need actual unified logging and the crude `trcVerbose`, but perhaps that would be a separate cleanup. Though the duplication is pretty awful.
>
> Hi @dholmes-ora, just a follow up question on this point. 
> 
> What do you think would be the best course of action for the time being?
> 
> Leave the duplication and then open another issue to handle the ```trcVerbose``` cleanup or remove the unified logging from this PR altogether?
> 
> Thanks for taking a look!

Well as the whole point of this PR is to add UL in this area, I suggest leaving the duplication and cleanup/remove trcVerbose seprately.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1470576539