RFR: 8336919: Cleanup and rename tags in placeholders code [v3]

[Coleen Phillimore]

On Thu, 25 Jul 2024 18:10:04 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change does some renaming of tags, fields and function name (resolve_super_or_fail => resolve_with_circularity_detection) in the Placeholders and SystemDictionary (class loading) code.  resolve_super_or_fail implied that it's always the super class, which it is not, especially with the upcoming changes to valhalla.  Renaming the function to resolve/load and check for circularity error is more accurate. These are changes made by @fparain brought over from the valhalla branch.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Whitespace and wording change.

In the current code, resolve_with_circularity_detection is only called for super classes or interfaces, so the comments are correct in the current code. These comments will need to be adjusted with the introduction of LoadableDescriptors in the valhalla repo, once this is merged in.  I fixed some of the other items though.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20279#issuecomment-2255764481