RFR: 8336919: Cleanup and rename tags in placeholders code [v3]

Coleen Phillimore coleenp at openjdk.org
Mon Jul 29 12:27:33 UTC 2024


On Mon, 29 Jul 2024 01:55:02 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Whitespace and wording change.
>
> src/hotspot/share/classfile/systemDictionary.cpp line 509:
> 
>> 507:   // The only thing that takes different action for is_superclass is dumping the static archive, which doesn't
>> 508:   // reach this path.
>> 509:   assert (!CDSConfig::is_dumping_static_archive(), "should not be parallel loading static archive");
> 
> Suggestion: "should not be dumping static archive"

adopted suggestion.

> src/hotspot/share/classfile/systemDictionary.hpp line 106:
> 
>> 104: 
>> 105:   static InstanceKlass* resolve_with_circularity_detection(Symbol* class_name,
>> 106:                                                            Symbol* super_name,
> 
> s/super_name/next_name/

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20279#discussion_r1695122534
PR Review Comment: https://git.openjdk.org/jdk/pull/20279#discussion_r1695122959


More information about the hotspot-runtime-dev mailing list