RFR: 8316131: runtime/cds/appcds/TestParallelGCWithCDS.java fails with JNI error [v3]

[David Holmes]

On Tue, 4 Jun 2024 06:16:38 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> The `runtime/cds/appcds/TestParallelGCWithCDS.java` test currently expects specific output. When running with a small heap, JVM could fail at different places with different output.
>> Updating the test if the expected output isn't there, checks for non-zero exit value and that the JVM hasn't crashed.
>> 
>> Tested with the following jtreg options on linux-x64:
>> 
>> -javaoptions:"-Xcomp -ea -esa -XX:CompileThreshold=100 -XX:+UnlockExperimentalVMOptions -server -XX:-TieredCompilation -XX:-UseCompressedOops -XX:+UnlockExperimentalVMOptions -XX:+UseJVMCICompiler -Xmx8m -Xms2m"
>> -timeout:25
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @dolmes-ora comments

Thanks. Updated logic is good. There is an issue with formatting though so please fix before integrating.

test/hotspot/jtreg/runtime/cds/appcds/TestParallelGCWithCDS.java line 122:

> 120:                                        "|(Initial heap size set to a larger value than the maximum heap size))";
> 121:                         out.shouldMatch(pattern);
> 122:                         out.shouldNotHaveFatalError();

The indentation is off here. All the double-quotes should line up and the `out.shouldMatch` line should be shifted left two spaces. Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19506#pullrequestreview-2095570816
PR Review Comment: https://git.openjdk.org/jdk/pull/19506#discussion_r1625509944