RFR: 8316131: runtime/cds/appcds/TestParallelGCWithCDS.java fails with JNI error [v3]

Calvin Cheung ccheung at openjdk.org
Tue Jun 4 15:24:00 UTC 2024


On Tue, 4 Jun 2024 07:38:02 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @dolmes-ora comments
>
> test/hotspot/jtreg/runtime/cds/appcds/TestParallelGCWithCDS.java line 122:
> 
>> 120:                                        "|(Initial heap size set to a larger value than the maximum heap size))";
>> 121:                         out.shouldMatch(pattern);
>> 122:                         out.shouldNotHaveFatalError();
> 
> The indentation is off here. All the double-quotes should line up and the `out.shouldMatch` line should be shifted left two spaces. Thanks

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19506#discussion_r1626203290


More information about the hotspot-runtime-dev mailing list