RFR: 8332362: Implement os::committed_in_range for MacOS and AIX [v6]
Robert Toyonaga
duke at openjdk.org
Mon Jun 17 19:09:14 UTC 2024
On Sat, 15 Jun 2024 05:52:26 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Robert Toyonaga has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add #else branch for non-AIX platforms.
>
> test/hotspot/jtreg/runtime/Thread/TestAlwaysPreTouchStacks.java line 119:
>
>> 117: if (isLinux()) {
>> 118: options.add( "-XX:-UseMadvPopulateWrite");
>> 119: }
>
> Please remove this. There have been discussions about this in [JDK-8324781](https://bugs.openjdk.org/browse/JDK-8324781), and I changed my mind about this. I think we should test the default, whatever the default is (and if pretouching by default is broken on Oracle Linux, so be it).
After merging master, it looks like a recent PR already adds `-XX:-UseMadvPopulateWrite` to this test. Should I remove that too? https://github.com/openjdk/jdk/pull/18592/files
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19455#discussion_r1643317324
More information about the hotspot-runtime-dev
mailing list