RFR: 8332362: Implement os::committed_in_range for MacOS and AIX [v6]

Thomas Stuefe stuefe at openjdk.org
Tue Jun 18 05:51:25 UTC 2024


On Mon, 17 Jun 2024 19:06:20 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/Thread/TestAlwaysPreTouchStacks.java line 119:
>> 
>>> 117:             if (isLinux()) {
>>> 118:                 options.add( "-XX:-UseMadvPopulateWrite");
>>> 119:             }
>> 
>> Please remove this. There have been discussions about this in [JDK-8324781](https://bugs.openjdk.org/browse/JDK-8324781), and I changed my mind about this. I think we should test the default, whatever the default is (and if pretouching by default is broken on Oracle Linux, so be it).
>
> After merging master, it looks like a recent PR already adds `-XX:-UseMadvPopulateWrite` to this test. Should I remove that too? https://github.com/openjdk/jdk/pull/18592/files

No, leave it in, please. There has been a misunderstanding.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19455#discussion_r1643842162


More information about the hotspot-runtime-dev mailing list