RFR: 8335007: Inline OopMapCache table

Stefan Karlsson stefank at openjdk.org
Wed Jun 26 08:14:11 UTC 2024


On Tue, 25 Jun 2024 13:26:33 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> OopMapCache uses a (closed hashing) table. The table is C-heap allocated. OopMapCache itself is also C-heap allocated. Since table size is fixed, we can just inline the table to OopMapCache and save one unnecessary pointer-hop on lookup.

I'm not a maintainer of this code, but this change looks good to me.

I reacted a little bit when I saw the `_size` usage in the array expression, thinking that you were using a member variable. It turns out that it is just a constant with a very unconventionally named (for HotSpot) constant. Would anyone object if we/I changed the name of these constants in a follow-up RFE?

-------------

Marked as reviewed by stefank (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19882#pullrequestreview-2141060623


More information about the hotspot-runtime-dev mailing list