RFR: 8319251: [REDO] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT

David Holmes dholmes at openjdk.org
Tue Mar 19 03:11:19 UTC 2024


On Tue, 20 Feb 2024 16:40:05 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> A fix to change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT.

Default switch looks good.

I'm surprised that the changes in VMProps.java were not already in place as they are needed regardless of what the default lock mode is. ???

test/jtreg-ext/requires/VMProps.java line 422:

> 420: 
> 421:     /**
> 422:      * @return "true" if compiler in use supports RTM and false otherwise.

Why did you put true in quotes?? The false is not in quotes. If anything it should be `{@code true}` and `{@code false}` but as we are never going to generate javadoc for this the formatting is immaterial.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17932#pullrequestreview-1945054556
PR Review Comment: https://git.openjdk.org/jdk/pull/17932#discussion_r1529623561


More information about the hotspot-runtime-dev mailing list