RFR: 8319251: [REDO] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT [v2]

[Daniel D. Daugherty]

On Tue, 19 Mar 2024 13:27:08 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> test/jtreg-ext/requires/VMProps.java line 422:
>> 
>>> 420: 
>>> 421:     /**
>>> 422:      * @return "true" if compiler in use supports RTM and false otherwise.
>> 
>> Why did you put true in quotes?? The false is not in quotes. If anything it should be `{@code true}` and `{@code false}` but as we are never going to generate javadoc for this the formatting is immaterial.
>
> I got the formatting for the comment from which ever existing comment that I copied
> to create the new ones. For whatever reason, these functions return String so "true"
> and "false" are accurate. I'll fix my new ones to all be the same, but I'm not going to
> try to clean up the existing ones.

Let me try to be more clear.

I updated the existing entry to `"true"` because the new functions that I added used `"true"`
because I copied that comment from an existing function. These functions return String so
I'm going to change the `false` to `"false"`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17932#discussion_r1531055092