RFR: 6942632: Hotspot should be able to use more than 64 logical processors on Windows [v9]
Saint Wesonga
duke at openjdk.org
Mon Mar 25 21:02:24 UTC 2024
On Tue, 19 Mar 2024 02:25:56 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Saint Wesonga has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Respect processor count from the job object
>
> src/hotspot/os/windows/os_windows.cpp line 4193:
>
>> 4191: }
>> 4192:
>> 4193: return logical_processors;
>
> Before returning please add a `log_debug(os)` statement indicating the number of logical processors discovered.
This message will not appear in the log if the logging statement is placed here because the [log configuration is initialized](https://github.com/openjdk/jdk/blob/8b9bf758801400e4491326cd4c90fc117b9d97e1/src/hotspot/share/runtime/threads.cpp#L449) after [initializing the os module](https://github.com/openjdk/jdk/blob/8b9bf758801400e4491326cd4c90fc117b9d97e1/src/hotspot/share/runtime/threads.cpp#L431). I have added logging code that will be executed only the first time the active processor count is retrieved.
> Please add a `log_debug(os)` statement indicating that this version does schedule all processor groups.
This message will not appear in the log if the logging statement is placed here because the [log configuration is initialized](https://github.com/openjdk/jdk/blob/8b9bf758801400e4491326cd4c90fc117b9d97e1/src/hotspot/share/runtime/threads.cpp#L449) after [initializing the os module](https://github.com/openjdk/jdk/blob/8b9bf758801400e4491326cd4c90fc117b9d97e1/src/hotspot/share/runtime/threads.cpp#L431). I have added logging code that will be executed only the first time the active processor count is retrieved.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17576#discussion_r1538233726
PR Review Comment: https://git.openjdk.org/jdk/pull/17576#discussion_r1538234035
More information about the hotspot-runtime-dev
mailing list