RFR: 6942632: Hotspot should be able to use more than 64 logical processors on Windows [v9]

[Saint Wesonga]

On Tue, 19 Mar 2024 02:29:34 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Sorry for the delay in getting back to this. There is a lot of API surface that I am not familiar with that I am trying to get my head around. The overall code structure and approach is looking very good - though I have one issue with the initialization process.
> 
> One thing that is missing though is a way to effectively test this given all the possible conditions that might be present:
> 
> * a job object exists, or not
> * processor groups exist, or not
> * affinity has been set, or not
> 
> I recognise it may be very difficult to create either a regression test or a gtest for this, but I would like to see some instructions on how to set up different scenarios and then check that `Runtime::availableProcessors()` reports what would be expected. Otherwise we have a ton of code here that is effectively untested.
> 
> I have made some suggestions for uniform logging statements so that we could use UL together with the test scenarios to check whether things are working as expected.
> 
> Thanks.

I have updated the PR with logging code and added a "Test Scenarios" section to the PR description outlining these scenarios. Please let me know if there is a better place to save this information. As far as I can tell, there is no standard Windows tool for creating job objects though.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17576#issuecomment-2019338910