RFR: 8329112: Clean up CDS checking of unsupported module options

[Ioi Lam]

- Renamed the functions to `check_unsupported_dumping_module_options()` and `has_unsupported_runtime_module_options()`, since their error messages are about VM options, not system properties.
- Consolidated the search of unsupported properties into a helper function.
- Removed obsolete code/comment in classLoader.cpp that suggests that `--patch-module` is allowed during dumping. Replace with an assertion that forbids patching when dumping.

-------------

Commit messages:
 - 8329112: Clean up CDS checking of unsupported module options

Changes: https://git.openjdk.org/jdk/pull/18492/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18492&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8329112
  Stats: 64 lines in 4 files changed: 16 ins; 15 del; 33 mod
  Patch: https://git.openjdk.org/jdk/pull/18492.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18492/head:pull/18492

PR: https://git.openjdk.org/jdk/pull/18492