RFR: 8329112: Clean up CDS checking of unsupported module options

[Calvin Cheung]

On Tue, 26 Mar 2024 16:38:44 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> - Renamed the functions to `check_unsupported_dumping_module_options()` and `has_unsupported_runtime_module_options()`, since their error messages are about VM options, not system properties.
> - Consolidated the search of unsupported properties into a helper function.
> - Removed obsolete code/comment in classLoader.cpp that suggests that `--patch-module` is allowed during dumping. Replace with an assertion that forbids patching when dumping.

I've one suggestion. Looks good otherwise.

src/hotspot/share/classfile/classLoader.cpp line 1134:

> 1132:       // Exploded build - attempt to locate class in its defining module's location.
> 1133:       assert(_exploded_entries != nullptr, "No exploded build entries present");
> 1134:       assert(!CDSConfig::is_dumping_archive(), "CDS doesn't support exploded build");

Suggestion: update the assert comment to `"CDS dumping doesn't support exploded build"`.

-------------

Marked as reviewed by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18492#pullrequestreview-1963836815
PR Review Comment: https://git.openjdk.org/jdk/pull/18492#discussion_r1541426210