RFR: 8329112: Clean up CDS checking of unsupported module options [v2]

[Ioi Lam]

> - Renamed the functions to `check_unsupported_dumping_module_options()` and `has_unsupported_runtime_module_options()`, since their error messages are about VM options, not system properties.
> - Consolidated the search of unsupported properties into a helper function.
> - Removed obsolete code/comment in classLoader.cpp that suggests that `--patch-module` is allowed during dumping. Replace with an assertion that forbids patching when dumping.

Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:

  @calvinccheung review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18492/files
  - new: https://git.openjdk.org/jdk/pull/18492/files/84f470d8..641763ac

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18492&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18492&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18492.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18492/head:pull/18492

PR: https://git.openjdk.org/jdk/pull/18492