RFR: 8329112: Clean up CDS checking of unsupported module options [v2]

[Matias Saavedra Silva]

On Wed, 27 Mar 2024 16:54:47 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> - Renamed the functions to `check_unsupported_dumping_module_options()` and `has_unsupported_runtime_module_options()`, since their error messages are about VM options, not system properties.
>> - Consolidated the search of unsupported properties into a helper function.
>> - Removed obsolete code/comment in classLoader.cpp that suggests that `--patch-module` is allowed during dumping. Replace with an assertion that forbids patching when dumping.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @calvinccheung review comments

Looks good, thanks!

-------------

Marked as reviewed by matsaave (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18492#pullrequestreview-1964719418