RFR: 8329112: Clean up CDS checking of unsupported module options [v2]

Ioi Lam iklam at openjdk.org
Wed Mar 27 16:54:47 UTC 2024


On Wed, 27 Mar 2024 16:17:01 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @calvinccheung review comments
>
> src/hotspot/share/classfile/classLoader.cpp line 1134:
> 
>> 1132:       // Exploded build - attempt to locate class in its defining module's location.
>> 1133:       assert(_exploded_entries != nullptr, "No exploded build entries present");
>> 1134:       assert(!CDSConfig::is_dumping_archive(), "CDS doesn't support exploded build");
> 
> Suggestion: update the assert comment to `"CDS dumping doesn't support exploded build"`.

Fixed. Thanks for the review.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18492#discussion_r1541486741


More information about the hotspot-runtime-dev mailing list