RFR: 8247449: Revisit the argument processing logic for MetaspaceShared::disable_optimized_module_handling() [v2]

[Matias Saavedra Silva]

On Wed, 27 Mar 2024 02:52:33 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> The changes include:
>> 
>> - refactor` CDSConfig::check_system_property()` into `CDSConfig:check_internal_module_property()` and `CDSConfig::check_incompatible_property()`;
>> - `CDSConfig:check_internal_module_property()` will be called from `Arguments::create_module_property()` and `Arguments::create_numbered_module_property()`;
>> - `CDSConfig::check_incompatible_property()` will be called from `Arguments::add_property()` only for `ExternalProperty`.
>> 
>> Passed tiers 1 - 3 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @iklam comments

Looks good! I just have one style option you might want to consider.

src/hotspot/share/cds/cdsConfig.cpp line 252:

> 250:   };
> 251: 
> 252:   for (uint i = 0; i < ARRAY_SIZE(incompatible_properties); i++) {

Since you aren't using the index for anything here, you could use a for each loop instead:
`for (const char* property : incompatible_properties) { ... }`

-------------

Marked as reviewed by matsaave (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18495#pullrequestreview-1964729798
PR Review Comment: https://git.openjdk.org/jdk/pull/18495#discussion_r1542011065