RFR: 8247449: Revisit the argument processing logic for MetaspaceShared::disable_optimized_module_handling() [v2]
Calvin Cheung
ccheung at openjdk.org
Thu Mar 28 00:08:40 UTC 2024
On Wed, 27 Mar 2024 20:43:42 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>>
>> @iklam comments
>
> src/hotspot/share/cds/cdsConfig.cpp line 252:
>
>> 250: };
>> 251:
>> 252: for (uint i = 0; i < ARRAY_SIZE(incompatible_properties); i++) {
>
> Since you aren't using the index for anything here, you could use a for each loop instead:
> `for (const char* property : incompatible_properties) { ... }`
Thanks. I've made the change.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18495#discussion_r1542167177
More information about the hotspot-runtime-dev
mailing list