RFR: 8321550: Update several runtime/cds tests to use vm flags or mark as flagless

[Matias Saavedra Silva]

On Wed, 27 Mar 2024 17:21:56 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> Simple update to a few CDS tests:
> 
> - add `@requires vm.flagless` if the test is using `ProcessTools.createLimitedTestJavaProcessBuilder()`;
> - some tests are using `ProcessTools.createLimitedTestJavaProcessBuilder()` by mistake; change it back to `ProcessTools.createTestJavaProcessBuilder()`.
> 
> Passed tiers 1 - 3 testing.

Change looks good but I have two format concerns. When you changed `createLimitedTestJavaProcessBuilder` to `createTestJavaProcessBuilder`, the arguments are no longer aligned.

test/hotspot/jtreg/runtime/cds/TestCDSVMCrash.java line 52:

> 50:         }
> 51:         // else this is the main test
> 52:         ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder("-XX:+CrashOnOutOfMemoryError",

The arguments are no longer aligned after your change

test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/ResolvedReferencesNotNullTest.java line 45:

> 43:         String whiteboxParam = SharedStringsUtils.getWbParam();
> 44: 
> 45:         ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder("-cp",

Same here

-------------

PR Review: https://git.openjdk.org/jdk/pull/18520#pullrequestreview-1964753833
PR Review Comment: https://git.openjdk.org/jdk/pull/18520#discussion_r1542034404
PR Review Comment: https://git.openjdk.org/jdk/pull/18520#discussion_r1542034617