RFR: 8321550: Update several runtime/cds tests to use vm flags or mark as flagless [v2]

Calvin Cheung ccheung at openjdk.org
Wed Mar 27 21:24:33 UTC 2024


On Wed, 27 Mar 2024 20:56:48 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   align arguments
>
> test/hotspot/jtreg/runtime/cds/TestCDSVMCrash.java line 52:
> 
>> 50:         }
>> 51:         // else this is the main test
>> 52:         ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder("-XX:+CrashOnOutOfMemoryError",
> 
> The arguments are no longer aligned after your change

Fixed.

> test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/ResolvedReferencesNotNullTest.java line 45:
> 
>> 43:         String whiteboxParam = SharedStringsUtils.getWbParam();
>> 44: 
>> 45:         ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder("-cp",
> 
> Same here

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18520#discussion_r1542064003
PR Review Comment: https://git.openjdk.org/jdk/pull/18520#discussion_r1542064038


More information about the hotspot-runtime-dev mailing list