RFR: 8329150: Remove CDS support for LatestMethodCache [v4]

Coleen Phillimore coleenp at openjdk.org
Wed Mar 27 23:16:32 UTC 2024


On Wed, 27 Mar 2024 21:04:44 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> The CDS support for LatestMethodCache has no meaningful performance benefit. I am removing it for simplcity.
>> 
>> I also cleaned up the code a bit
>> - No need to put LatestMethodCache in universe.hpp.
>> - No need to use TRAPS in the init function
>> - No need to malloc the LatestMethodCache objects
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   aligned and simplified comments

src/hotspot/share/memory/universe.cpp line 949:

> 947: Method* LatestMethodCache::get_method() {
> 948:   if (klass() == nullptr) return nullptr;
> 949:   InstanceKlass* ik = InstanceKlass::cast(klass());

Sorry for the bits and pieces.  Hopefully the last thing.  Can _klass be a InstanceKlass so we don't need this cast?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18516#discussion_r1542141501


More information about the hotspot-runtime-dev mailing list