RFR: 8325883: Move Monitor Deflation reporting out of safepoint cleanup [v2]

[Daniel D. Daugherty]

On Thu, 28 Mar 2024 15:50:57 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Moved monitor logging out of the safepoint cleanup code to intervals in the MonitorDeflationThread, and made logging come out at the specified level (Info, Debug or Trace).
>> 
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove old spin-locking comment

Thumbs up. I think I only have nit comments here.

src/hotspot/share/runtime/synchronizer.cpp line 1958:

> 1956: }
> 1957: 
> 1958: // This function can be called by the monitor deflation thread or it can be called when

nit: s/monitor deflation thread/MonitorDeflationThread/

src/hotspot/share/runtime/synchronizer.cpp line 1978:

> 1976:   // When exiting, only log the interesting entries at the Info level.
> 1977:   // When called at intervals by the MonitorDeflationThread, log output at the Trace level since
> 1978:   // there can be a lot of it.

nit: Might want to reflow this comment after "log output" and move the
rest to the next line.

test/hotspot/jtreg/runtime/Monitor/MonitorUsedDeflationThresholdTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2021, 2024, Oracle and/or its affiliates. All rights reserved.

Reviewed this file with whitespace changes disabled. Hopefully I
didn't miss anything that way...

test/hotspot/jtreg/runtime/Monitor/MonitorUsedDeflationThresholdTest.java line 165:

> 163:             testProcess1();
> 164:             testProcess2();
> 165:             testProcess3();

Thanks for expanding the testing!

-------------

Marked as reviewed by dcubed (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18528#pullrequestreview-1966916353
PR Review Comment: https://git.openjdk.org/jdk/pull/18528#discussion_r1543411058
PR Review Comment: https://git.openjdk.org/jdk/pull/18528#discussion_r1543412964
PR Review Comment: https://git.openjdk.org/jdk/pull/18528#discussion_r1543422681
PR Review Comment: https://git.openjdk.org/jdk/pull/18528#discussion_r1543421740