RFR: 8325883: Move Monitor Deflation reporting out of safepoint cleanup [v2]

[Coleen Phillimore]

On Thu, 28 Mar 2024 18:06:45 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove old spin-locking comment
>
> src/hotspot/share/runtime/synchronizer.cpp line 1958:
> 
>> 1956: }
>> 1957: 
>> 1958: // This function can be called by the monitor deflation thread or it can be called when
> 
> nit: s/monitor deflation thread/MonitorDeflationThread/

Fixed, yes, that's better for pattern matching.

> src/hotspot/share/runtime/synchronizer.cpp line 1978:
> 
>> 1976:   // When exiting, only log the interesting entries at the Info level.
>> 1977:   // When called at intervals by the MonitorDeflationThread, log output at the Trace level since
>> 1978:   // there can be a lot of it.
> 
> nit: Might want to reflow this comment after "log output" and move the
> rest to the next line.

fixed.

> test/hotspot/jtreg/runtime/Monitor/MonitorUsedDeflationThresholdTest.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2021, 2024, Oracle and/or its affiliates. All rights reserved.
> 
> Reviewed this file with whitespace changes disabled. Hopefully I
> didn't miss anything that way...

My editor strips trailing blanks and my commit command updates copyrights, so you should have seen any other weird formatting in this diff.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18528#discussion_r1543441150
PR Review Comment: https://git.openjdk.org/jdk/pull/18528#discussion_r1543441338
PR Review Comment: https://git.openjdk.org/jdk/pull/18528#discussion_r1543443568