RFR: 8332610: Remove unused nWakeups ObjectMonitor [v3]

David Holmes dholmes at openjdk.org
Wed May 22 05:21:09 UTC 2024


On Wed, 22 May 2024 05:11:33 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Delete the second nWakeups
>
> src/hotspot/share/runtime/objectMonitor.cpp line 1017:
> 
>> 1015:     // Note that the counter is not protected by a lock or updated by atomics.
>> 1016:     // That is by design - we trade "lossy" counters which are exposed to
>> 1017:     // races during updates for a lower probe effect.
> 
> The same comment block needs deleting at line 874 too.

Actually, I think the comment blocks are referring to the `OM_PERFDATA_OP(FutileWakeups, inc());` calls not the `nWakeups` local variable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19326#discussion_r1609272429


More information about the hotspot-runtime-dev mailing list