RFR: 8302744: Refactor Hotspot container detection code [v4]
Severin Gehwolf
sgehwolf at openjdk.org
Tue May 28 12:51:21 UTC 2024
On Tue, 28 May 2024 04:25:28 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with four additional commits since the last revision:
>>
>> - Make read_string() take the output buffer size
>> - Fix style for read_numerical_key_value
>> - Use assertions for required parameters
>> - Use boolean for tuples
>
> test/hotspot/gtest/runtime/test_cgroupSubsystem_linux.cpp line 71:
>
>> 69: class TestController : public CgroupController {
>> 70: private:
>> 71: char* _path;
>
> Make it const char* const, and init via initializer list in constructor
Used initializer list.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19060#discussion_r1617186380
More information about the hotspot-runtime-dev
mailing list