RFR: 8340103: Add internal set_flag function to VMATree [v11]

Johan Sjölen jsjolen at openjdk.org
Tue Nov 5 14:42:29 UTC 2024


On Tue, 5 Nov 2024 09:06:29 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> They should be static and const, yes.
>> 
>> Re: ephemeral utility class. I do prefer using functions as opposed to methods, but it'd be nice to wrap them in a namespace or class that can be shortened and used outside of `VMATree`.
>
> Okay

>Also, TreapNode* should be const.

Right, gotta back off from that again. The issue is that `val()` is non-const, which is correct: we should be able to change the value of a node. But, that means that the node argument cannot be `const`, because (quoting my compiler: `'this' argument discards qualifiers`. It's just an unfortunately clunky part of C++, it seems.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20994#discussion_r1829472868


More information about the hotspot-runtime-dev mailing list