RFR: 8340103: Add internal set_flag function to VMATree [v11]
Johan Sjölen
jsjolen at openjdk.org
Wed Nov 6 10:28:04 UTC 2024
On Tue, 5 Nov 2024 09:06:00 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> I'd just do curly brace initialization the same way as paren init. I don't think our style guide says anything, but the typical style that I see in C++ code is this dense variant.
>>
>> Edit: See example code in https://en.cppreference.com/w/cpp/language/aggregate_initialization and search for "uniform init" in https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines
>
> But it is not uniform if we end up with three different initialization styles: the old way of `object(a, b, c);` the new way of `object{a, b, c};` and plain array/struct init, which overwhelmingly seems to use spaces around curlies: `= { a, b, c };` .
Yeah, I don't care too much about what we do here to be honest. If you want spaces around curlies, we can do that :).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20994#discussion_r1830743529
More information about the hotspot-runtime-dev
mailing list