RFR: 8339288: Improve diagnostic logging runtime/cds/DeterministicDump.java [v2]

[Matias Saavedra Silva]

On Sat, 9 Nov 2024 04:28:30 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Two suggestions:

That's a good idea! I think my example output is a little confusing because there are actually two differences in it. Using your idea, the output would look like this:

[First diff: map file #1 (SharedArchiveFile0.map)]
[ro region          0x00000008005a2000 - 0x0000000800ea7058   9457752 bytes]
 0x00000008005a2cb0:   6f66000a8da9ffff 6c61766f6d655272                                     ......forRemoval 
 0x00000008005a2cc0: @@ Symbol            32 java/lang/VersionProps
>0x00000008005a2cc0:   616a0016959bffff 2f676e616c2f6176 506e6f6973726556 0000000073706f72   ......java/lang/ VersionProps....
 0x00000008005a2ce0: @@ Symbol            24 java_version
 0x00000008005a2ce0:   616a000c335cffff 69737265765f6176 0000000000006e6f                    ..\3..java_version......

[First diff: map file #2 (SharedArchiveFile1.map)]
[ro region          0x00000008005a2000 - 0x0000000800ea7058   9457752 bytes]
 0x00000008005a2cb0:   6f66000ae5fcffff 6c61766f6d655272                                     ......forRemoval
 0x00000008005a2cc0: @@ Symbol            32 java/lang/VersionProps
>0x00000008005a2cc0:   616a00169955ffff 2f676e616c2f6176 506e6f6973726556 0000000073706f72   ..U...java/lang/ VersionProps....
 0x00000008005a2ce0: @@ Symbol            24 java_version
 0x00000008005a2ce0:   616a000ca147ffff 69737265765f6176 0000000000006e6f                    ..G...java_version......

Byte #5910530 at line #235510 word #0:
SharedArchiveFile0.map: 616a0016959bffff 
SharedArchiveFile1.map: 616a00169955ffff 

I make sure extra lines are printed after the diff but I can include "..." on top of that as well.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21913#issuecomment-2470955786