RFR: 8339288: Improve diagnostic logging runtime/cds/DeterministicDump.java [v2]

[Matias Saavedra Silva]

On Sat, 9 Nov 2024 04:28:30 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Now prints preceding lines and region name
>
> Two suggestions:
> 
> (1) I think it will be good to print an indicator on the line that differs. Something like
> 
>  [First diff: map file #2 (SharedArchiveFile1.map)]
>  [ro region          0x00000008005a2000 - 0x0000000800ea7058   9457752 bytes] 
>  0x00000008005a2cb0:   6f66000ae5fcffff 6c61766f6d655272                                     ......forRemoval
>  0x00000008005a2cc0: @@ Symbol            32 java/lang/VersionProps
>  0x00000008005a2cc0:   616a00169955ffff 2f676e616c2f6176 506e6f6973726556 0000000073706f72   ..U...java/lang/VersionProps....
>  0x00000008005a2ce0: @@ Symbol            24 java_version
>>0x00000008005a2ce0:   616a000ca147ffff 69737265765f6176 0000000000006e6f                    ..G...java_version......
> 
> 
> (2) Sometimes an object spans over many lines. It will be good to remember the first line of the very last object (the `0x00000008005a2ce0: @@ Symbol` in your example). If that line is more than 4 lines above the first diff, then print something like this:
> 
> 
>  0x00000008005a2ce0: @@ Symbol            24 java_version
>  [....]
> 
> 
> before printing the rest of the output.

Thanks for the feedback and reviews @iklam and @calvinccheung !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21913#issuecomment-2475019043