RFR: 8330606: Redefinition doesn't but should verify the new klass [v2]

[Coleen Phillimore]

On Thu, 14 Nov 2024 20:28:01 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated the test with some comments.
>
> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineVerifyError.java line 124:
> 
>> 122:         try {
>> 123:             RedefineClassHelper.redefineClass(verifyErrorMirror, dump());
>> 124:             VerifyError err = new VerifyError("verify me now");
> 
> Which of these two lines are expected to throw a VerifyError?
> 
> Is the VerifyError because you can't redefine VerifyError, or is there something invalid about the how the class is redefined?

We call the verifier during redefinition with the 'true' parameter, so the redefinition will throw VerifyError when it's loading the new class file version.  There's a broken stackmap in the new version of this VerifyError class (ie. I asmifyied it and commented out something in it).  I updated the test with some comments.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22116#discussion_r1842913318