RFR: 8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values

[David Holmes]

On Mon, 28 Oct 2024 06:20:39 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> We have observed `ThreadsListHandle.sanity_vm failed with unequal ThreadList values` several times on linux-x64 and linux-aarch64, by jdk17u/jdk21u/jdk24 etc.
> Before the root cause of the test failure has been fixed, should we disable the unstable check of ThreadsListHandle.sanity_vm ThreadList values, to make less of CI noisy.
> 
> Additional testing:
> 
> - [x] release build and run the `gtest/GTestWrapper.java` on linux-x64
> - [x] fastdebug build and run the `gtest/GTestWrapper.java` on linux-x64
> - [x] slowdebug build and run the `gtest/GTestWrapper.java` on linux-x64

The `util` vs `until` typo needs fixing everywhere.

I guess this is okay  - similar to ProblemListing. For the record we don't see any failures of this that I could find.

test/hotspot/gtest/runtime/test_ThreadsListHandle.cpp line 297:

> 295:           << "thr->_threads_hazard_ptr must match tlh2.list()";
> 296:     // Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values,
> 297:     // util the root cause of test failure(JDK-8315141) has been fixed

Suggestion:

    // until the root cause of test failure(JDK-8315141) has been fixed

test/hotspot/gtest/runtime/test_ThreadsListHandle.cpp line 347:

> 345:             << "thr->_threads_hazard_ptr must match tlh3.list()";
> 346:         // Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values,
> 347:         // util the root cause of test failure(JDK-8315141) has been fixed

Suggestion:

        // until the root cause of test failure(JDK-8315141) has been fixed

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21734#pullrequestreview-2437710703
PR Review Comment: https://git.openjdk.org/jdk/pull/21734#discussion_r1843225316
PR Review Comment: https://git.openjdk.org/jdk/pull/21734#discussion_r1843225510