RFR: 8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values [v2]
SendaoYan
syan at openjdk.org
Fri Nov 15 06:21:22 UTC 2024
On Fri, 15 Nov 2024 06:00:10 GMT, David Holmes <dholmes at openjdk.org> wrote:
> The `util` vs `until` typo needs fixing everywhere.
Thanks for the review, the typo bug has been fixed.
> I guess this is okay - similar to ProblemListing. For the record we don't see any failures of this that I could find.
Maybe we should add `problemlist` label for [JDK-8315141](https://bugs.openjdk.org/browse/JDK-8315141) after this PR integrated.
> test/hotspot/gtest/runtime/test_ThreadsListHandle.cpp line 175:
>
>> 173: << "thr->_threads_hazard_ptr must match tlh2.list()";
>> 174: // Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values,
>> 175: // util the root cause of test failure(JDK-8315141) has been fixed
>
> Suggestion:
>
> // until the root cause of test failure(JDK-8315141) has been fixed
Thanks, the typo bug has been fixed.
> test/hotspot/gtest/runtime/test_ThreadsListHandle.cpp line 297:
>
>> 295: << "thr->_threads_hazard_ptr must match tlh2.list()";
>> 296: // Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values,
>> 297: // util the root cause of test failure(JDK-8315141) has been fixed
>
> Suggestion:
>
> // until the root cause of test failure(JDK-8315141) has been fixed
Thanks, the typo bug has been fixed.
> test/hotspot/gtest/runtime/test_ThreadsListHandle.cpp line 347:
>
>> 345: << "thr->_threads_hazard_ptr must match tlh3.list()";
>> 346: // Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values,
>> 347: // util the root cause of test failure(JDK-8315141) has been fixed
>
> Suggestion:
>
> // until the root cause of test failure(JDK-8315141) has been fixed
Thanks, the typo bug has been fixed.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21734#issuecomment-2478040628
PR Review Comment: https://git.openjdk.org/jdk/pull/21734#discussion_r1843237433
PR Review Comment: https://git.openjdk.org/jdk/pull/21734#discussion_r1843237517
PR Review Comment: https://git.openjdk.org/jdk/pull/21734#discussion_r1843237608
More information about the hotspot-runtime-dev
mailing list