RFR: 8342011: Conditionally compile ReservedHeapSpace compressed heap support

[David Holmes]

On Mon, 14 Oct 2024 00:29:36 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to ReservedHeapSpace to conditionally include the
> support for compressed oops only in 64bit builds.  This code is unused and
> inapplicable in 32bit builds.  Further, it contains code that is problematic
> in a 32bit build.  See the JBS issue for details.
> 
> Testing: mach5 tier1, GHA testing

One nit but looks good.

Thanks

src/hotspot/share/memory/virtualspace.cpp line 645:

> 643:   if (UseCompressedOops) {
> 644:     NOT_LP64(ShouldNotReachHere();)
> 645: #ifdef _LP64

`#ifndef ... else ...` would look marginally better IMO.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21484#pullrequestreview-2371359678
PR Review Comment: https://git.openjdk.org/jdk/pull/21484#discussion_r1802458838