RFR: 8342011: Conditionally compile ReservedHeapSpace compressed heap support [v2]
Stefan Karlsson
stefank at openjdk.org
Thu Oct 17 07:08:15 UTC 2024
On Wed, 16 Oct 2024 08:01:01 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>>
>> improve conditionalization
>
> src/hotspot/share/memory/virtualspace.hpp line 138:
>
>> 136:
>> 137: // Compressed oop support is not relevant in 32bit builds.
>> 138: #ifdef _LP64
>
> Suggestion:
>
>
> // Compressed oop support is not relevant in 32bit builds.
> #ifdef _LP64
>
>
> The `#endif // _LP64` below have blank lines before and after, so it seems more consistent to also have it here.
Could you indicate if you saw this comment?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21484#discussion_r1804223509
More information about the hotspot-runtime-dev
mailing list