RFR: 8342011: Conditionally compile ReservedHeapSpace compressed heap support [v2]

Kim Barrett kbarrett at openjdk.org
Fri Oct 18 19:40:49 UTC 2024


On Thu, 17 Oct 2024 07:05:47 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> src/hotspot/share/memory/virtualspace.hpp line 138:
>> 
>>> 136: 
>>> 137:   // Compressed oop support is not relevant in 32bit builds.
>>> 138: #ifdef _LP64
>> 
>> Suggestion:
>> 
>> 
>>   // Compressed oop support is not relevant in 32bit builds.
>> #ifdef _LP64
>> 
>> 
>> The `#endif // _LP64` below have blank lines before and after, so it seems more consistent to also have it here.
>
> Could you indicate if you saw this comment?

Oops, missed that.  Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21484#discussion_r1806943791


More information about the hotspot-runtime-dev mailing list