RFR: 8339488: Extended NPE message doesn't handle CONSTANT_Dynamic [v2]

[Leonid Mesnik]

On Fri, 6 Sep 2024 14:55:47 GMT, Oli Gillespie <ogillespie at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/condy/CondyExtendedNullPointerTest.java line 28:
>> 
>>> 26:  * @bug 8339488
>>> 27:  * @summary Test extended NullPointerException message in method with CONSTANT_Dynamic.
>>> 28:  * @requires vm.flagless
>> 
>> Is there are any reasons to ignore all additional vm flags? Usually the test should accept any flags and be flagless only if there are known reasons for this. Even if it doesn't looks to be useful to run in different modes. Usually to stress comiplers with different bycodes.
>> You don't need to run test in an additional configurations.
>
> I copied from CondyLDCTest - I figured the authors must have thought about something I didn't.

I quickly looked through test history and didn't find any reason for this. Could you please change
'createLimitedTestJavaProcessBuilder'
to 
'createTestJavaProcessBuilder'
and remove 
line 28
@requires vm.flagless.

I'll file a bug to fix CondyLDCTest also.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20889#discussion_r1747351553