RFR: 8338626: CDS handling of JAR Class-Path attribute should allow / separator on Windows

David Holmes dholmes at openjdk.org
Wed Sep 11 01:34:11 UTC 2024


On Wed, 11 Sep 2024 01:25:27 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Also, the modified function is only called during CDS dump time for setting up the shared class paths for the app class loader.
>
> To me it sounds like the logic should be always using `/` to locate and then use file_seperator to rewrite to a classpath filesystem entry.

No strike that, the logic is more complex.

> Before the patch, on Windows, it only works with '\' (the default file separator). e.g. java -cp dir1\A.jar ... .

So you want to be able to process the classpath if it uses `/` instead of `` on Windows? Is that how classpath processing normally works on Windows?

The JBS issue says it is fixing the processing of the Class-path attribute, not the processing of the classpath entries. Or maybe I have just misconstrued exactly what this is fixing - the Class-path attribute itself is immaterial here??

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20924#discussion_r1752995016


More information about the hotspot-runtime-dev mailing list