RFR: 8338626: CDS handling of JAR Class-Path attribute should allow / separator on Windows

Ioi Lam iklam at openjdk.org
Wed Sep 11 06:47:08 UTC 2024


On Wed, 11 Sep 2024 04:21:23 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> No strike that, the logic is more complex.
>> 
>>> Before the patch, on Windows, it only works with '\' (the default file separator). e.g. java -cp dir1\A.jar ... .
>> 
>> So you want to be able to process the classpath if it uses `/` instead of `` on Windows? Is that how classpath processing normally works on Windows?
>> 
>> The JBS issue says it is fixing the processing of the Class-path attribute, not the processing of the classpath entries. Or maybe I have just misconstrued exactly what this is fixing - the Class-path attribute itself is immaterial here??
>
> To better describe what we're fixing, how about changing the JBS title to the following?
> `CDS: allow the use of / separator on Windows to locate entries from the Class-Path attribute`

How about this?

> ClassLoaderExt::process_jar_manifest() should allow / separator on Windows

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20924#discussion_r1753196281


More information about the hotspot-runtime-dev mailing list