RFR: 8338626: ClassLoaderExt::process_jar_manifest() should allow / separator on Windows [v2]

[David Holmes]

On Thu, 12 Sep 2024 00:15:22 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> On Windows, we can use '/' as the file separator in the classpath but not in the `Class-Path:` attribute.
>> This patch is to enable the use of '/' as the file separator in the `Class-Path:`attribute on Windows.
>> 
>> Passed tiers 1 - 3 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @iklam comment

Changes requested by dholmes (Reviewer).

src/hotspot/share/classfile/classLoaderExt.cpp line 217:

> 215:     const char* dir_tail = strrchr(dir_name, sep);
> 216: #ifdef _WINDOWS
> 217:     // On Windows, we also support forward slash as the file separator when locating entries in the Class-Path: attribute.

Suggestion:

    // On Windows, we also support forward slash as the file separator when locating entries in the classpath entry.

The forward slash is not being used in relation to any Class-path attribute here.

-------------

PR Review: https://git.openjdk.org/jdk/pull/20924#pullrequestreview-2299008532
PR Review Comment: https://git.openjdk.org/jdk/pull/20924#discussion_r1755914235