RFR: 8338626: ClassLoaderExt::process_jar_manifest() should allow / separator on Windows [v4]
Alan Bateman
alanb at openjdk.org
Fri Sep 13 06:29:04 UTC 2024
On Thu, 12 Sep 2024 00:12:14 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> `foo/bar.jar` is a relative file path. `lib.jar` is a relative URL. On the surface it might appear that they can be combined but there are many reasons why this can't work in general. So if the code is in the VM then it's always going to be approximation to how this JAR file attribute is handled by the application class loader.
>
>> > ClassLoaderExt::process_jar_manifest() should allow / separator on Windows
>
> I've updated the titles of the PR and JBS.
Just to repeat what I said previously, the value of Class-Path attribute is a sequence of relative URLs. The code in ClassLoaderExt::process_jar_manifest will work for some cases but in general, the appending used in this function can't be worked to combine a file path and URL path.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20924#discussion_r1758253550
More information about the hotspot-runtime-dev
mailing list