RFR: 8338626: ClassLoaderExt::process_jar_manifest() should allow / separator on Windows [v4]

Ioi Lam iklam at openjdk.org
Fri Sep 13 07:38:06 UTC 2024


On Fri, 13 Sep 2024 06:26:56 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>>> > ClassLoaderExt::process_jar_manifest() should allow / separator on Windows
>> 
>> I've updated the titles of the PR and JBS.
>
> Just to repeat what I said previously, the value of Class-Path attribute is a sequence of relative URLs. The code in ClassLoaderExt::process_jar_manifest will work for some cases but in general, the appending used in this function can't be worked to combine a file path and URL path.

Alan, could you show us some cases where ClassLoaderExt::process_jar_manifest() will fail. IIUC, the failures won't be Windows-specific (i.e., orthogonal to the \ vs / issues in this bug) but rather will happen on all platforms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20924#discussion_r1758342215


More information about the hotspot-runtime-dev mailing list