RFR: 8338912: CDS: Segmented roots array [v8]

[Aleksey Shipilev]

On Thu, 12 Sep 2024 22:52:46 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make sure HeapRootSegments representation does not hold garbage
>
> src/hotspot/share/cds/archiveUtils.cpp line 387:
> 
>> 385: }
>> 386: 
>> 387: size_t HeapRootSegments::segment_offset(size_t seg_idx) {
> 
> Suggestion: add assert on `seg_idx` (as in line 378).

Done. Also done in `size_in_bytes`, even though it might be excessive, given the immediate call to `size_in_elems`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20858#discussion_r1758429714