RFR: 8298614: Support CDS heap dumping for non-G1 collectors

[David Holmes]

On Fri, 13 Sep 2024 20:20:39 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> This patch upstreams [JDK-8333222](https://bugs.openjdk.org/browse/JDK-8333222) from the Leyden repo. Additional test fixes not in that patch were added. Verified with tier 1-5 tests.

Generally looks good but two small issues.

Thanks.

src/hotspot/share/cds/heapShared.cpp line 469:

> 467:                                         p2i((address)G1CollectedHeap::heap()->reserved().start()),
> 468:                     UseCompressedOops ? p2i(CompressedOops::end()) :
> 469:                                         p2i((address)G1CollectedHeap::heap()->reserved().end()));

Does this work if you build a minimal VM with only SerialGC? I would expect the build to fail.

test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/IncompatibleOptions.java line 111:

> 109:         }
> 110: 
> 111:         // ParallelGC and SerialGC now supports dumping heap objects

The "now" will be dated very soon. The comment is redundant really.

But do we not need other tests for Serial/Parallel and other flags combinations (or do they not apply)?

-------------

PR Review: https://git.openjdk.org/jdk/pull/21004#pullrequestreview-2305668670
PR Review Comment: https://git.openjdk.org/jdk/pull/21004#discussion_r1760440649
PR Review Comment: https://git.openjdk.org/jdk/pull/21004#discussion_r1760442288