RFR: 8298614: Support CDS heap dumping for non-G1 collectors [v2]

[Matias Saavedra Silva]

On Mon, 16 Sep 2024 01:33:27 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   David and Ioi comments
>
> src/hotspot/share/cds/heapShared.cpp line 469:
> 
>> 467:                                         p2i((address)G1CollectedHeap::heap()->reserved().start()),
>> 468:                     UseCompressedOops ? p2i(CompressedOops::end()) :
>> 469:                                         p2i((address)G1CollectedHeap::heap()->reserved().end()));
> 
> Does this work if you build a minimal VM with only SerialGC? I would expect the build to fail.

Yes, I verified locally that this works on a minimal build

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21004#discussion_r1763574977