RFR: 8340092: [Linux] containers/systemd/SystemdMemoryAwarenessTest.java failing on some systems [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Mon Sep 16 14:16:19 UTC 2024
> Please review this trivial test fix. The test fails if the `<slice>.d` directory already exists (for some reason). It needs to exist for the test to work. But if it exists we ignore the failure, thus using `Files.createDirectories()`.
>
> As a benefit I've also added `exclusiveAccess.dirs=.` to the `systemd` test directory to match container tests in `docker` folder and added `TRUNCATE_EXISTING` and `CREATE` open options for files in the `<slice>.d` directory. Both of which should ensure the test runs more reliably.
>
> Testing:
> - [ ] GHA
> - [x] Manual testing by creating the directory first, running the test. Failed. The same handshake passes after the patch.
>
> Thanks!
Severin Gehwolf has updated the pull request incrementally with three additional commits since the last revision:
- Cleanup files when systemd --user fails
- Skip test if systemd user manager not properly working
- Add CREATE open option.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/20989/files
- new: https://git.openjdk.org/jdk/pull/20989/files/807bb898..4fde8dfd
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=20989&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=20989&range=00-01
Stats: 40 lines in 1 file changed: 23 ins; 4 del; 13 mod
Patch: https://git.openjdk.org/jdk/pull/20989.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20989/head:pull/20989
PR: https://git.openjdk.org/jdk/pull/20989
More information about the hotspot-runtime-dev
mailing list